Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kep-3983: revise beta requirements #4966

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kep-3983: revise beta requirements #4966

wants to merge 1 commit into from

Conversation

sohankunkerkar
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sohankunkerkar
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@sohankunkerkar sohankunkerkar mentioned this pull request Nov 18, 2024
Open
12 tasks
@haircommander
Copy link
Contributor

Would you also mention this is consistent with out --config flag works for posterity?

@sohankunkerkar
kep-3983: revise beta requirements
3bb31c8 
Signed-off-by: Sohan Kunkerkar <[email protected]>
@sohankunkerkar
Copy link
Member Author

@SergeyKanzhelev @haircommander could you review this?

@sohankunkerkar sohankunkerkar mentioned this pull request Jan 10, 2025
Draft
@haircommander
Copy link
Contributor

haircommander commented Jan 10, 2025 •
edited
Loading

I think we decided not to go with a default, as technically --config doesn't have a default either AFAIR

I misread the section this was responding to, this PR does this!

@haircommander
Copy link
Contributor

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@haircommander haircommander

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sohankunkerkar @k8s-ci-robot @haircommander @SergeyKanzhelev