Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-cl: remove nested CAPI provider subproject #8093

Merged
merged 1 commit into from
Oct 28, 2024
Merged

sig-cl: remove nested CAPI provider subproject #8093

merged 1 commit into from
Oct 28, 2024

Conversation

neolit123
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2024
@neolit123 neolit123 force-pushed the 1.32-remove-cluster-api-provider-nested branch from eba4463 to 081687b Compare October 1, 2024 17:05
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 1, 2024
@neolit123
Copy link
Member Author

/cc @fabriziopandini @vincepri

@neolit123 neolit123 mentioned this pull request Oct 1, 2024
Merged
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2024
@Priyankasaggu11929
Copy link
Member

/approve

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2024
@neolit123 neolit123 force-pushed the 1.32-remove-cluster-api-provider-nested branch from 081687b to 8a5aa45 Compare October 16, 2024 17:14
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 16, 2024
@neolit123
Copy link
Member Author

rebased @fabriziopandini @Priyankasaggu11929 please reapply LGTM.

@Priyankasaggu11929
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 17, 2024
@neolit123 neolit123 force-pushed the 1.32-remove-cluster-api-provider-nested branch from 8a5aa45 to 082833f Compare October 28, 2024 07:41
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 28, 2024
@neolit123
Copy link
Member Author

@Priyankasaggu11929 please help with the approval.
also we need assistance with the archival:

@Priyankasaggu11929
Copy link
Member

/lgtm
/approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@Priyankasaggu11929
Copy link
Member

also we need assistance with the archival kubernetes/org#5194

@neolit123, assigned ^ issue to myself. I'll address it.

@neolit123
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 61674e2 into kubernetes:master Oct 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@fabriziopandini fabriziopandini

@Priyankasaggu11929 Priyankasaggu11929

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neolit123 @fabriziopandini @Priyankasaggu11929 @k8s-ci-robot