Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA: Add docs about AKS and EKS with Cilium #7655

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adrianmoisey
Copy link
Member

Ref:

What type of PR is this?

/kind documentation

What this PR does / why we need it:

More docs to help users

Which issue(s) this PR fixes:

Fixes #6915

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/vertical-pod-autoscaler labels Jan 5, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2025
Copy link
Contributor

@voelzmo voelzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few wording suggestions from my side.

vertical-pod-autoscaler/docs/faq.md Outdated Show resolved Hide resolved
vertical-pod-autoscaler/docs/faq.md Outdated Show resolved Hide resolved
vertical-pod-autoscaler/docs/faq.md Outdated Show resolved Hide resolved
vertical-pod-autoscaler/docs/faq.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adrianmoisey
Once this PR has been reviewed and has the lgtm label, please assign kwiesmueller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrianmoisey
Copy link
Member Author

Thanks for the review, I've made those suggested changed. Can you take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical Pod Autoscaler is not recreating pods at runtime
3 participants