VPA: Remove v1beta2

[adrianmoisey]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove v1beta2 API

Which issue(s) this PR fixes:

Fixes #5922

Special notes for your reviewer:

I'm unsure if there is anything else that needs to happen to remove this API

Does this PR introduce a user-facing change?

Remove deprecated v1beta2 APIs

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[voelzmo]

Hey @adrianmoisey thanks for doing this PR! I love changes which consist basically only of removing lines!

I have two asks before this is ready to be merged from my point of view:

• I think we should add a comment to the README similar to what we did for the migration from v1beta1 to v1beta2. Contrary to the previous api migration, there aren't any changes necessary for users (v1 didn't make any incompatible changes), except for changing v1beta2 to v1 in their VPA objects.
  • People can find out if they need to to anything by looking at the recommender metrics, e.g. sum(vpa_recommender_vpa_objects_count) by (api)
• There seems to be an unused redis.yaml and redis_deprecated.yaml in the examples folder, and they still use v1beta2. I think we should also remove those two. Or are those used in a weird test setup somewhere?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adrianmoisey
Once this PR has been reviewed and has the lgtm label, please assign kwiesmueller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adrianmoisey]

• I think we should add a comment to the README similar to what we did for the migration from v1beta1 to v1beta2. Contrary to the previous api migration, there aren't any changes necessary for users (v1 didn't make any incompatible changes), except for changing v1beta2 to v1 in their VPA objects.

  • People can find out if they need to to anything by looking at the recommender metrics, e.g. sum(vpa_recommender_vpa_objects_count) by (api)

Yup, good call out here. Done in a193b1a

• There seems to be an unused redis.yaml and redis_deprecated.yaml in the examples folder, and they still use v1beta2. I think we should also remove those two. Or are those used in a weird test setup somewhere?

This is a little bit of a a strange one. These aren't for v1beta2, they're for v1beta1.
From what I can tell, they are referenced in the MIGRATE.md file.

I was considering deleting the YAML files and the README, but I imagine that someone on an old (ancient?) version may need those instructions to migrate. Additionally, the MIGRATE.md file is quite out of date (ie: it doesn't mention v1)

I'm unsure if we should leave them as is, and remove them all in the future. Or just delete them all now, as they are in git history.

Thoughts?