-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ingress-nginx] expose custom tcp and udp ports in ingress-nginx-controller #11850
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: commx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @commx! |
Hi @commx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest-failed |
Is this file |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The PR adds missing container port mappings for custom TCP and UDP services so they are exposed by the ingress-nginx-controller container.
Prior to these changes, users may have defined custom TCP/UDP ports to be handled by ingress-nginx but they will have no effect because they are not exposed from the container.
Which issue(s) this PR fixes:
No existing issue found.
Special notes for your reviewer:
None.
Does this PR introduce a user-facing change?: