Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Enrich Grafana plugin panels #3690

Merged
merged 1 commit into from
Nov 17, 2023
Merged

✨ Enrich Grafana plugin panels #3690

merged 1 commit into from
Nov 17, 2023

Conversation

Kavinjsir
Copy link
Contributor

Description

Add panels to show:

  • work queue depth
  • number of workers in use
  • unfinished seconds

Slightly changed panels position for better UI.

Screenshot 2023-11-08 at 5 17 20 PM

Motivation

This PR aims to partially resolve #3651

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 8, 2023
@k8s-ci-robot
Copy link
Contributor

@Kavinjsir: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-kubebuilder-e2e-k8s-1-26-6
  • /test pull-kubebuilder-e2e-k8s-1-27-3
  • /test pull-kubebuilder-e2e-k8s-1-28-0
  • /test pull-kubebuilder-test

Use /test all to run all jobs.

In response to this:

/retest pull-kubebuilder-e2e-k8s-1-26-6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Kavinjsir
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-26-6

@Kavinjsir
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-27-3

@Kavinjsir
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-28-0

camilamacedo86
camilamacedo86 reviewed Nov 9, 2023
View reviewed changes
pkg/plugins/optional/grafana/v1alpha/scaffolds/internal/templates/runtime.go
@@ -105,6 +105,62 @@ const controllerRuntimeTemplate = `{
"title": "Reconciliation Metrics",
"type": "row"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shows nice.
I think it would be great if we update the Grafana Plugin docs as well
It seems that we have an image with its result.

Also, what do you think about adding (if not) the metrics used and when they are useful there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 Thx for this good reminder!
I tried updated docs in the relative part:
https://deploy-preview-3690--kubebuilder.netlify.app/plugins/grafana-v1-alpha#unfinished-seconds
How would you like this?

camilamacedo86
camilamacedo86 reviewed Nov 9, 2023
View reviewed changes
pkg/plugins/optional/grafana/v1alpha/scaffolds/internal/templates/runtime.go
"datasource": "${DS_PROMETHEUS}",
"fieldConfig": {
"defaults": {
"mappings": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider having a way to preview the graphs in the CI / GitHub actions before merging this one? So that we can check more efficiently if all is still fine. WDYT?

camilamacedo86
camilamacedo86 reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kavinjsir

Just to clarify: I am OK to get this merged after we update the docs to reflect the changes.

Btw, thank you a lot for your amazing contribution 🥇

@Kavinjsir
✨ Enrich Grafana plugin panels
65b1201 
Add panels to show work queue depth, number of workers in use, and unfinished seconds

Signed-off-by: tonyjin <[email protected]>
camilamacedo86
camilamacedo86 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 26ee671 into kubernetes-sigs:master Nov 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@everettraven everettraven Awaiting requested review from everettraven

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The grafana dashboard generated by the Grafana plugin is missing some key metrics.
3 participants
@Kavinjsir @k8s-ci-robot @camilamacedo86