Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install.md #657

Merged
merged 2 commits into from
Oct 10, 2020
Merged

Update install.md #657

merged 2 commits into from
Oct 10, 2020

Conversation

avoidik
Copy link
Contributor

@avoidik avoidik commented Oct 8, 2020

Add small comment about Windows elevated command prompt

Fixes # #631
Related issue: # #643

@avoidik
Update install.md
9fa7017 
Add small comment about Windows elevated command prompt
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @avoidik!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2020
ahmetb
ahmetb reviewed Oct 8, 2020
View reviewed changes
site/content/docs/user-guide/setup/install.md Outdated
@@ -71,7 +71,7 @@ Krew self-hosts).

1. Make sure `git` is installed on your system.
1. Download `krew.exe` from the [Releases][releases] page to a directory.
1. Launch a command-line window (`cmd.exe`) and navigate to that directory.
1. Launch a command-line window (`cmd.exe`) with elevated privileges (to update symbolic link) and navigate to that directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I'm not sure if the (...) part is necessary.

If you think it is, maybe rewrite it as (since the installation requires use of symbolic links) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, why not

@avoidik
Update install.md
b6da67d 
More precise description about the symbolic link requirement
@corneliusweig
Copy link
Contributor

/lgtm
/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avoidik, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit a46c82c into kubernetes-sigs:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb left review comments

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@corneliusweig corneliusweig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avoidik @k8s-ci-robot @corneliusweig @ahmetb