Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove NoArgs positional arguments validation #3573

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/cmd/kind/build/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import (
// NewCommand returns a new cobra.Command for building
func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
cmd := &cobra.Command{
Args: cobra.NoArgs,
// TODO(bentheelder): more detailed usage
Use: "build",
Short: "Build one of [node-image]",
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/kind/completion/completion.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import (
// NewCommand returns a new cobra.Command for cluster creation
func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
cmd := &cobra.Command{
Args: cobra.NoArgs,
Use: "completion",
Short: "Output shell completion code for the specified shell (bash, zsh or fish)",
Long: longDescription,
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/kind/create/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import (
// NewCommand returns a new cobra.Command for cluster creation
func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
cmd := &cobra.Command{
Args: cobra.NoArgs,
Use: "create",
Short: "Creates one of [cluster]",
Long: "Creates one of local Kubernetes cluster (cluster)",
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/kind/delete/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import (
// NewCommand returns a new cobra.Command for cluster deletion
func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
cmd := &cobra.Command{
Args: cobra.NoArgs,
// TODO(bentheelder): more detailed usage
Use: "delete",
Short: "Deletes one of [cluster]",
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/kind/export/export.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import (
// NewCommand returns a new cobra.Command for export
func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
cmd := &cobra.Command{
Args: cobra.NoArgs,
// TODO(bentheelder): more detailed usage
Use: "export",
Short: "Exports one of [kubeconfig, logs]",
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/kind/get/get.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import (
// NewCommand returns a new cobra.Command for get
func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
cmd := &cobra.Command{
Args: cobra.NoArgs,
// TODO(bentheelder): more detailed usage
Use: "get",
Short: "Gets one of [clusters, nodes, kubeconfig]",
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/kind/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ type flagpole struct {
func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
flags := &flagpole{}
cmd := &cobra.Command{
Args: cobra.NoArgs,
Use: "kind",
Short: "kind is a tool for managing local Kubernetes clusters",
Long: "kind creates and manages local Kubernetes clusters using Docker container 'nodes'",
Expand Down
1 change: 0 additions & 1 deletion pkg/cmd/kind/version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ var gitCommit = ""
// NewCommand returns a new cobra.Command for version
func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command {
cmd := &cobra.Command{
Args: cobra.NoArgs,
Use: "version",
Short: "Prints the kind CLI version",
Long: "Prints the kind CLI version",
Expand Down