Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Default to topology flavor in NodeDrainTimeoutSpec #11727

Merged
merged 1 commit into from
Jan 22, 2025
Merged

🐛 Default to topology flavor in NodeDrainTimeoutSpec #11727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e/node_drain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ type NodeDrainTimeoutSpecInput struct {

// Flavor, if specified, must refer to a template that uses a Cluster with ClusterClass.
// The cluster must use a KubeadmControlPlane and a MachineDeployment.
// If not specified, "node-drain" is used.
// If not specified, "topology" is used.
Flavor *string

// Allows to inject a function to be run after test namespace is created.
Expand Down Expand Up @@ -138,7 +138,7 @@ func NodeDrainTimeoutSpec(ctx context.Context, inputGetter func() NodeDrainTimeo
ClusterctlConfigPath: input.ClusterctlConfigPath,
KubeconfigPath: input.BootstrapClusterProxy.GetKubeconfigPath(),
InfrastructureProvider: infrastructureProvider,
Flavor: ptr.Deref(input.Flavor, "node-drain"),
Flavor: ptr.Deref(input.Flavor, "topology"),
Namespace: namespace.Name,
ClusterName: clusterName,
KubernetesVersion: input.E2EConfig.GetVariable(KubernetesVersion),
Expand Down
Loading