-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: eks e2e with coredns addon #5269
Conversation
The behaviour of EKS has changed in relation to addons when there are no nodes. Previously when enabling the coredns addon in a cluster with no nodes it would have a status of 'DOWNGRADED'. But recently AWS made a change and the status now shows as `UPDATING` with a failed health check. To get the e2e passing the coredns addon has been removed from the AWSManagedControlPlane used in the test. We will need to follow up on this with a change to the addons reconciliation. Signed-off-by: Richard Case <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@richardcase: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-provider-aws-e2e-eks |
@richardcase: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Closing in favour of #5239 |
/close |
@richardcase: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The behaviour of EKS has changed in relation to addons when there are no nodes. Previously when enabling the coredns addon in a cluster with no nodes it would have a status of 'DOWNGRADED'. But recently AWS made a change and the status now shows as
UPDATING
with a failed health check.To get the e2e passing the coredns addon has been removed from the AWSManagedControlPlane used in the test. We will need to follow up on this with a change to the addons reconciliation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5237
Special notes for your reviewer:
Checklist:
Release note: