Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Clarify that creating-a-cluster.md steps are creating a ROSA HCP cluster #5268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Jan 8, 2025

What type of PR is this?
/kind documentation

What this PR does / why we need it:
The more explicit product name is ROSA HCP, see issue for more details

Which issue(s) this PR fixes:
Fixes #5257

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stevekuznetsov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2025
@mjlshen
Copy link
Contributor Author

mjlshen commented Jan 8, 2025

/assign mzazrivec serngawy

Just as an fyi!

@k8s-ci-robot
Copy link
Contributor

@mjlshen: GitHub didn't allow me to assign the following users: mzazrivec.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign mzazrivec serngawy

Just as an fyi!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating-a-cluster.md document should correctly mention ROSA HCP (not just ROSA)
3 participants