-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EKS Security Group tag updation from AWSManagedControlPlane #5229
base: main
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @vishu2498. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vishu2498 thanks for the PR, could you please write unit tests for this as well?
@Ankitasw I have added tests to PR. |
@Ankitasw Can you please re-check the PR? I have updated it. |
HI @Ankitasw . Can you please check the PR again? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vishu2498: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test pull-cluster-api-provider-aws-test |
@vishu2498: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
New changes are detected. LGTM label has been removed. |
Hi @Ankitasw . Can you please re-approve and merge this PR? |
@Ankitasw Can you please check it once again? |
Hello @Ankitasw |
@Ankitasw any help on this? |
@Ankitasw @dlipovetsky @luthermonson Can we please get help on this? |
@vishu2498 please update release notes, you can take reference from other PRs |
What type of PR is this?
/kind feature
/kind bug
What this PR does / why we need it:
This PR implements the functionality of having the same tags everywhere in EKS cluster which are provided in
spec.additionalTags
section ofAWSManagedControlPlane
to the default cluster security group of EKS created by AWS.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):For this bug: #5223