-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump CAPI to v1.9.3 #338
🌱 Bump CAPI to v1.9.3 #338
Conversation
/hold I think we should merge #337 first, and maybe cut a CAAPH release with that before rebasing and merging this. |
fef6c89
to
a11eb51
Compare
a11eb51
to
5142170
Compare
/hold cancel |
5142170
to
2c67c0e
Compare
2c67c0e
to
717d4be
Compare
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/assign @Jont828 This is passing but for the API diff, which I think is unavoidable. Let me know what you think. |
I'm okay with the API diff given that it's just caused by the controller runtime version bump and not a change to our API. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jont828, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup
What this PR does / why we need it:
Updates CAPI to v1.9.3.
Which issue(s) this PR fixes:
Fixes #311
Special notes for your reviewer:
See controller-runtime v0.19 release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.19.0
See CAPI 1.8 - 1.9 migration guide: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md
CAPZ's PR, for comparison: kubernetes-sigs/cluster-api-provider-azure#5316
CAPA's PR, for comparison: kubernetes-sigs/cluster-api-provider-aws#5209