Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump CAPI to v1.9.3 #338

Merged

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Dec 30, 2024

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.9.3.

Which issue(s) this PR fixes:

Fixes #311

Special notes for your reviewer:

See controller-runtime v0.19 release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.19.0
See CAPI 1.8 - 1.9 migration guide: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md
CAPZ's PR, for comparison: kubernetes-sigs/cluster-api-provider-azure#5316
CAPA's PR, for comparison: kubernetes-sigs/cluster-api-provider-aws#5209

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 30, 2024
@mboersma
Copy link
Contributor Author

/hold

I think we should merge #337 first, and maybe cut a CAAPH release with that before rebasing and merging this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2024
@mboersma mboersma removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@mboersma mboersma force-pushed the bump-capi-one-nine-three branch from fef6c89 to a11eb51 Compare December 30, 2024 19:22
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@mboersma mboersma removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@mboersma mboersma force-pushed the bump-capi-one-nine-three branch from a11eb51 to 5142170 Compare January 3, 2025 22:32
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@mboersma
Copy link
Contributor Author

mboersma commented Jan 3, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2025
@mboersma mboersma force-pushed the bump-capi-one-nine-three branch from 5142170 to 2c67c0e Compare January 6, 2025 14:49
@mboersma mboersma removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@mboersma mboersma force-pushed the bump-capi-one-nine-three branch from 2c67c0e to 717d4be Compare January 6, 2025 16:42
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@mboersma mboersma removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-addon-provider-helm-apidiff-main 717d4be link false /test pull-cluster-api-addon-provider-helm-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mboersma
Copy link
Contributor Author

mboersma commented Jan 6, 2025

/assign @Jont828

This is passing but for the API diff, which I think is unavoidable. Let me know what you think.

@Jont828
Copy link
Contributor

Jont828 commented Jan 6, 2025

I'm okay with the API diff given that it's just caused by the controller runtime version bump and not a change to our API.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit b6ed08a into kubernetes-sigs:main Jan 6, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPI v1.9.0-beta.0 has been released and is ready for testing
3 participants