Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update examples for mount permissions to 0775 #2310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Update examples for mount permissions to 0775 #2310

wants to merge 2 commits into from
+18 −18

Conversation

m-anyac
Copy link

@m-anyac m-anyac commented Dec 29, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update examples for mount permissions of directory and file to 0775
Fix install document

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: Update examples for mount permissions of directory and file to 0775

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 29, 2024
@k8s-ci-robot k8s-ci-robot requested review from cvvz and gnufied December 29, 2024 00:59
@k8s-ci-robot
Copy link
Contributor

Welcome @m-anyac!

It looks like this is your first PR to kubernetes-sigs/azurefile-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azurefile-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 29, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Hi @m-anyac. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 29, 2024
jsafrane
jsafrane reviewed Jan 2, 2025
View reviewed changes
pkg/azurefile/azurefile_options.go Outdated
@@ -70,7 +70,7 @@ func (o *DriverOptions) AddFlags() *flag.FlagSet {
fs.BoolVar(&o.EnableGetVolumeStats, "enable-get-volume-stats", true, "allow GET_VOLUME_STATS on agent node")
fs.BoolVar(&o.EnableKataCCMount, "enable-kata-cc-mount", false, "enable Kata Confidential Containers mount")
fs.BoolVar(&o.AppendMountErrorHelpLink, "append-mount-error-help-link", true, "Whether to include a link for help with mount errors when a mount error occurs.")
fs.Uint64Var(&o.MountPermissions, "mount-permissions", 0777, "mounted folder permissions")
fs.Uint64Var(&o.MountPermissions, "mount-permissions", 0775, "mounted folder permissions")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a breaking change. If I have an app that counts with 777 as the default and I update to this code, my application breaks. This needs to be announced properly, at least with a "breaking change" warning in the release notes.

I would personally also bump the major version, but I am not sure what are rules in this repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jan, thanks for pointing this out. It works on my end with 777. Could you provide more details about the crash, such as any error messages or related information?

Copy link
Contributor

@nearora-msft nearora-msft Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edreed This could be breaking change as we are making the permissions more restrictive. Is it a hard requirement to move to 0775 as default?
Should we just update the storageclass and other examples, or should we make this code change and mention in the release notes so that the users are aware?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsafrane this will revert to 777 thanks

@nearora-msft
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: m-anyac
Once this PR has been reviewed and has the lgtm label, please assign andyzhangx for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m-anyac m-anyac changed the title feat: set default mount permissions for SMB to 0775 fix: Update examples for mount permissions of directory and file to 0775 Jan 7, 2025
@m-anyac m-anyac changed the title fix: Update examples for mount permissions of directory and file to 0775 fix: Update examples for mount permissions to 0775 Jan 7, 2025
@m-anyac
Copy link
Author

m-anyac commented Jan 7, 2025

Hi Andy @andyzhangx, could I get review from you?

I think I have no permission to add a reviewer to this PR.
Screenshot 2025-01-06 185128

@andyzhangx
Copy link
Member

@m-anyac
if you want to make more secure, then why not use 0755 ? and I don't think you need to change all examples, you only need to add a comment after 0777, e.g. 0777 # modify this permission if you want to enhance the security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nearora-msft nearora-msft nearora-msft left review comments

@jsafrane jsafrane jsafrane left review comments

@cvvz cvvz Awaiting requested review from cvvz

@gnufied gnufied Awaiting requested review from gnufied

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m-anyac @k8s-ci-robot @nearora-msft @andyzhangx @jsafrane