-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add UT for filewatcher #2788
Conversation
Hi @Zhupku. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
faa3e2e
to
af28bb5
Compare
25ec44a
to
fa4f7c2
Compare
/ok-to-test |
fa4f7c2
to
4a1375f
Compare
@Zhupku: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, Zhupku The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request includes changes to improve the handling of program termination and adds a test for the
WatchFileForChanges
function. The most important changes include the introduction of a separateexit
function and the addition of a comprehensive test for file watching.Improvements to program termination handling:
pkg/filewatcher/filewatcher.go
: Introduced a separateexit
function to handle program termination, replacing direct calls toos.Exit
with this function. [1] [2]Addition of tests:
pkg/filewatcher/filewatcher_test.go
: Added a new test for theWatchFileForChanges
function, including a mockexit
function to capture exit codes and simulate file changes.<!-- Thanks for sending a pull request! Here are some tips for you:https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/release.md#issue-kind-label
-->
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: