Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make all-push a1 instance image support #2306

Closed

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Jan 22, 2025

What type of PR is this?

/kind cleanup

What is this PR about? / Why do we need it?

Fix make all-push a1 instance image support

Today make all-push does not create and push an a1 instance compatible image, which is blocking v1.39.x release.

This PR fixes the Makefile typo.

How was this change tested?

❯ export DOCKER_CLI_EXPERIMENTAL=enabled
trap "docker buildx rm multiarchimage-buildertest" EXIT
docker buildx create --driver-opt=image=moby/buildkit:v0.12.5 --bootstrap --use --name multiarchimage-buildertest

loudecho "Set up QEMU"
# See https://github.com/docker/setup-qemu-action
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes

loudecho "Push manifest list containing amazon linux and windows based images to GCR"
export IMAGE=208536326202.dkr.ecr.us-west-2.amazonaws.com/test
export TAG=v1.39.0
export VERSION=$PULL_BASE_REF
make -j $(nproc) all-push

All expected images appeared

❯ crane ls 208536326202.dkr.ecr.us-west-2.amazonaws.com/test | grep "v1.39"
v1.39.0-linux-arm64-al2
v1.39.0-windows-amd64-ltsc2019
v1.39.0-fips-windows-amd64-ltsc2019
v1.39.0-fips
v1.39.0-fips-linux-arm64-al2023
v1.39.0-fips-windows-amd64-ltsc2022
v1.39.0-linux-amd64-al2023
v1.39.0
v1.39.0-fips-linux-amd64-al2023
v1.39.0-linux-arm64-al2023
v1.39.0-windows-amd64-ltsc2022

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andrewsirenko. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2025
Copy link

Code Coverage Diff

This PR does not change the code coverage

@AndrewSirenko
Copy link
Contributor Author

/close

#2305 jinx

@k8s-ci-robot
Copy link
Contributor

@AndrewSirenko: Closed this PR.

In response to this:

/close

#2305 jinx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants