Fix cloudbuild.sh target #2280
Merged
Fix cloudbuild.sh target #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Catlett <[email protected]>
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
Code Coverage DiffThis PR does not change the code coverage |
k8s-ci-robot
added
the
lgtm
torredil
approved these changes
Jan 6, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What is this PR about? / Why do we need it?
hack/cloudbuild.shreferences invalid makefile targetall-push-for-release, it should beall-push- this causes all of our commits tomasterto fail to build (and would break building images for release as well).How was this change tested?
Manually
Does this PR introduce a user-facing change?