-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignoreNotFound flag to KubectlDelete.java #2898
Add ignoreNotFound flag to KubectlDelete.java #2898
Conversation
Welcome @awesominat! |
extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlDelete.java
Show resolved
Hide resolved
/lgtm If you could add a unit test in a follow up PR that would be appreciated. Thanks for the contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ananya2001-an, awesominat, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sure, I will work on creating a unit test |
This PR fixes #2876, an issue where attempting to delete a resource that doesn't exist throws an exception and causes the user to catch the exception.
Now, by setting the ignoreNotFound flag, exceptions don't have to be explicitly caught.