Fix order-dependent flakiness in KubernetesReconcilerCreatorTest.java

[yijut2]

Describe the bug
The order dependent flakiness was detected when KubernetesReconcilerCreatorTest.java was run before the KubernetesInformerCreatorTest.java. The error appeared at line 157 in KubernetesInformerCreatorTest.java. It was suppose to get 1 result the calling getRequestedFor()for specific urlPattern, however, the actual result was 2.

Fix log
The reason that the flakiness showed up was due to the object SharedInformerFactory. Since in the KubernetesReconcilerCreatorTest.java, we called startAllRegisteredInformers in the test and registered the V1Pod, but did not call stopAllRegisteredInformers to stop the registration, and then when next test class was run, there were already something in the database. Eventually, that lead to the unexpected output 2 when we called getRequestedFor()for specific urlPattern. To fix this order dependent flakiness, I added sharedInformerFactory.stopAllRegisteredInformers() at the end of the test testSimplePodController() in KubernetesReconcilerCreatorTest.java. This can make sure there won't be 2 instance with specific QueryParam came from different test class being stored in the database.

Java Version
Java 17

To Reproduce
mvn install -pl spring -am -DskipTests
(must setup iDFlakies on a Maven project - https://github.com/UT-SE-Research/iDFlakies)
mvn -pl spring idflakies:detect -Ddetector.detector_type=random-class-method -Ddt.randomize.rounds=10 -Ddt.detector.original_order.all_must_pass=false

Expected behavior
When calling the getRequestedFor() method in KubernetesInformerCreatorTest, we should get the return value as 1 since we only generated the object with specific QueryParam once in this test file.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: yijut2 (485a04e)

[k8s-ci-robot]

Welcome @yijut2!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

Thank you for the PR!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yijut2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment