Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct apiVersion name #2444

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

runzhen
Copy link
Contributor

@runzhen runzhen commented Feb 18, 2025

What this PR does / why we need it:
Use the correct apiVersion name, fixed the "resource mapping not found" error when installing the runtime

@runzhen
Copy link
Contributor Author

runzhen commented Feb 18, 2025

hi @andreyvelich , could you please take a look this PR ?

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great catch, thank you for fixing it @runzhen!
Btw, we are still working with @tenzen-y to make MPI Plugin working with Kubeflow Trainer as part of: #2217
After that, we will design runtimes for ML libs that require MPI for distributed training, e.g.:

  • DeepSpeed
  • MLX

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0b765d6 into kubeflow:master Feb 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants