Add Helm chart for kubeflow trainer

[ChenYi015]

What this PR does / why we need it:

Close #1197

Checklist:

• Docs included if any changes are user facing

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andreyvelich]

Thank you for doing this @ChenYi015!
Did you get a chance to explore Kueue script to generate Helm Charts from Kustomize manifests ?
I think, that should significantly help us to keep Kustomize and Charts in sync.

https://github.com/kubernetes-sigs/kueue/blob/main/hack/update-helm.sh

[ChenYi015]

I will take a look at the shell script, it is a bit complicated. I think it may be more easier to sync manifests templated by Helm charts to Kustomize manifests, WDYT?

[ChenYi015]

I have added a shell script hack/sync-manifests. Now one can execute make sync-manifests to sync the Kustomize manifests from the manifests templated by the Helm chart.

[andreyvelich]

Thanks for this effort @ChenYi015!
@tenzen-y @kannon92 @ahg-g @astefanutti @Electronic-Waste @kubeflow/wg-training-leads What do you think about it ?
Should we go other way around to sync Helm Charts to Kustomize Manifests ?
We can use the same approach for JobSet/Kueue if that is easier.

[andreyvelich]

cc @kubeflow/wg-manifests-leads @kubeflow/release-team @varodrig to review script of sync Kustomize + Helm automatically.

[andreyvelich]

cc @franciscojavierarceo

[andreyvelich]

Is there any way for us to import JobSet Helm charts into Kubeflow Trainer Helm charts ?
Or user has to install two Helm charts separately ?
E.g. JobSet might have charts in 0.8.0 release: kubernetes-sigs/jobset#774
cc @kannon92 @ahg-g @astefanutti @Electronic-Waste @kubeflow/wg-training-leads

[ChenYi015]

We can declare the JobSet Helm chart as a dependency in Chart.yaml as follows if it has been released:

dependencies:
- name: jobset
  version: 1.0.0
  repository: https://kubernetes-sigs.github.io/jobset

Then we do not have to install two Helm charts separately, ref: https://helm.sh/docs/chart_best_practices/dependencies/.

[ahg-g]

@ChenYi015 are you able to take over kubernetes-sigs/jobset#774 and address remaining comments? The person who raised the PR is not responsive, and I am unfortunately not a Helm chart expert, so hard for me to advise and continue his work.

[ChenYi015]

@ahg-g Yes, I am willing to raise another PR to do that.

[ahg-g]

Wonderful, very much appreciated 👍

[ChenYi015]

@ahg-g I have raised a PR to the jobset repo, PTAL when you have time.