Fix missing external types in apply configurations #2429
Conversation
|
/cc @andreyvelich @tenzen-y Could you please give this a review? |
| @@ -39,13 +39,30 @@ kube::codegen::gen_helpers \ | |||
| "${TRAINER_ROOT}/pkg/apis" | |||
|
|
|||
| # Generate clients. | |||
| externals=( | |||
| "sigs.k8s.io/jobset/api/jobset/v1alpha2.JobSetSpec:sigs.k8s.io/jobset/client-go/applyconfiguration/jobset/v1alpha2" | |||
There was a problem hiding this comment.
Do we need to add batch/v1 Job as well? Or this JobSet import can automatically handle the batch/v1 Job typed?
There was a problem hiding this comment.
You're absolutely right!
I've created kubernetes-sigs/jobset#782 so it'll be pulled transitively.
There was a problem hiding this comment.
Great effort across projects!
/lgtm
/approve
Signed-off-by: Antonin Stefanutti <[email protected]>
astefanutti
force-pushed
the
pr-applyconfig-exts
branch
from
7082845 to
e5d81f6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds the external types the Trainer API depends on to the code-generator command so the generated client apply configurations are complete and do not rely on "non-apply" types.
Checklist: