Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Fixed namespace in tests #11545

Merged
merged 1 commit into from
Jan 27, 2025
Merged

chore(test): Fixed namespace in tests #11545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,12 @@ jobs:
- name: Forward API port
run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888

- name: Forward MySQL port
run: ./.github/resources/scripts/forward-port.sh "kubeflow" "mysql" 3306 3306

- name: API integration tests v1
working-directory: ./backend/test/integration
run: go test -v ./... -namespace ${NAMESPACE} -args -runIntegrationTests=true
run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true

- name: Collect test results
if: always()
Expand Down Expand Up @@ -145,7 +148,7 @@ jobs:

- name: API integration tests v2
working-directory: ./backend/test/v2/integration
run: go test -v ./... -namespace ${NAMESPACE} -args -runIntegrationTests=true
run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true

- name: Collect test results
if: always()
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/upgrade-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,21 @@ jobs:
with:
k8s_version: ${{ matrix.k8s_version }}

- name: Forward API port
run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888

- name: Prepare upgrade tests
working-directory: backend/test/integration
run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Prepare
run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Prepare

- name: Prepare verification tests
working-directory: backend/test/integration
run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Verify
run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Verify

- name: Prepare upgrade tests v2
working-directory: backend/test/v2/integration/
run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Prepare
run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Prepare

- name: Prepare verification tests v2
working-directory: backend/test/v2/integration
run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Verify
run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Verify
4 changes: 1 addition & 3 deletions backend/test/integration/db_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ func (s *DBTestSuite) TestInitDBClient_MySQL() {
viper.Set("DBDriverName", "mysql")
viper.Set("DBConfig.MySQLConfig.DBName", "mlpipeline")
// The default port-forwarding IP address that test uses is different compared to production
if *localTest {
viper.Set("DBConfig.MySQLConfig.Host", "localhost")
}
viper.Set("DBConfig.MySQLConfig.Host", "localhost")
duration, _ := time.ParseDuration("1m")
db := cm.InitDBClient(duration)
assert.NotNil(t, db)
Expand Down
Loading