-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(manifests): Revert PSS changes in manifests #11487
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ricardo M. Oliveira <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rimolive is that not a distribution specific thing, so openshift only and not Kubernetes in general? I ran Kubeflow on openshift before and it is possible to do it rootless. We are really following Kubernetes best practices here according to https://kubernetes.io/docs/concepts/security/pod-security-standards/. So I propose to not revert it, but rather that you post the error message here and we try to fix it for openshift. |
@rimolive if there are confidential manifests involved we can also do a private session. |
@juliusvonkohout There are no confidential information involved, no worries! I'm talking specifically about the /hold |
Can you just comment out the runas with a hashtag to #runAs...? This way we keep all information for later. It could be that we need to modify some dockerfiles to support runasanyuser, if not even better :-) |
Description of your changes:
The changes introduced in #11462 broke manifests deployment in OpenShift environments. We need a more coordinated effort to add these PSS requirements as other WGs are requesting.
cc @HumairAK @juliusvonkohout
Checklist: