chore(test): Fixed namespace in tests

Signed-off-by: Helber Belmiro <[email protected]>
kubeflow · Jan 21, 2025 · c4b0fc7 · c4b0fc7
1 parent 3e423d8
commit c4b0fc7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
@@ -109,9 +109,12 @@ jobs:
       - name: Forward API port
         run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
 
+      - name: Forward MySQL port
+        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "mysql" 3306 3306
+
       - name: API integration tests v1
         working-directory: ./backend/test/integration
-        run: go test -v ./... -namespace ${NAMESPACE} -args -runIntegrationTests=true
+        run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true
 
       - name: Collect test results
         if: always()
@@ -145,7 +148,7 @@ jobs:
 
       - name: API integration tests v2
         working-directory: ./backend/test/v2/integration
-        run: go test -v ./... -namespace ${NAMESPACE} -args -runIntegrationTests=true
+        run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true
 
       - name: Collect test results
         if: always()

diff --git a/.github/workflows/upgrade-test.yml b/.github/workflows/upgrade-test.yml
@@ -33,18 +33,21 @@ jobs:
         with:
           k8s_version: ${{ matrix.k8s_version }}
 
+      - name: Forward API port
+        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
+
       - name: Prepare upgrade tests
         working-directory: backend/test/integration
-        run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Prepare
+        run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Prepare
 
       - name: Prepare verification tests
         working-directory: backend/test/integration
-        run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Verify
+        run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Verify
 
       - name: Prepare upgrade tests v2
         working-directory: backend/test/v2/integration/
-        run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Prepare
+        run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Prepare
 
       - name: Prepare verification tests v2
         working-directory: backend/test/v2/integration
-        run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Verify
+        run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Verify
diff --git a/backend/test/integration/db_test.go b/backend/test/integration/db_test.go
@@ -48,9 +48,7 @@ func (s *DBTestSuite) TestInitDBClient_MySQL() {
 	viper.Set("DBDriverName", "mysql")
 	viper.Set("DBConfig.MySQLConfig.DBName", "mlpipeline")
 	// The default port-forwarding IP address that test uses is different compared to production
-	if *localTest {
-		viper.Set("DBConfig.MySQLConfig.Host", "localhost")
-	}
+	viper.Set("DBConfig.MySQLConfig.Host", "localhost")
 	duration, _ := time.ParseDuration("1m")
 	db := cm.InitDBClient(duration)
 	assert.NotNil(t, db)