Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): sync with kubeflow/pipelines 2.0.3 #1408

Merged
merged 254 commits into from
Oct 27, 2023
Merged

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Oct 27, 2023

Description of your changes:
sync with kubeflow/pipelines 2.0.3.

Checklist:

Googler and others added 30 commits June 26, 2023 11:27
…n /frontend/server (#9592)

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) to 4.2.4 and updates ancestor dependency [@aws-sdk/credential-providers](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/credential-providers). These dependencies need to be updated together.


Updates `fast-xml-parser` from 4.0.11 to 4.2.4
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v4.0.11...v4.2.4)

Updates `@aws-sdk/credential-providers` from 3.241.0 to 3.348.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/credential-providers/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.348.0/packages/credential-providers)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-type: indirect
- dependency-name: "@aws-sdk/credential-providers"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…s #9704. Part of #9706. (#9705)

* Use GKE stable release channel to unblock presubmit tests

* update TODO comment
…on (#9694)

* Remove redundant handleVersionSelected helper.

* Unify variable name in handleVersionSelected() helper.
docs(components): Revert doc changes from preview sync

PiperOrigin-RevId: 546062400
docs(components): Revert doc changes from preview sync

PiperOrigin-RevId: 546110190
…h v1 and v2 (#9693)

* Change the logic of ResourceSelector to make it is able to be used in
both v1 and v2.
Remove ResourceSelectorV2.

* Remove snapshot.
docs(components): Revert doc changes from preview sync

PiperOrigin-RevId: 546959930
…n /frontend/server (#9685)

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) to 4.2.5 and updates ancestor dependency [@aws-sdk/credential-providers](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/credential-providers). These dependencies need to be updated together.


Updates `fast-xml-parser` from 4.2.4 to 4.2.5
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v4.2.4...v4.2.5)

Updates `@aws-sdk/credential-providers` from 3.348.0 to 3.359.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/credential-providers/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.359.0/packages/credential-providers)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-type: indirect
- dependency-name: "@aws-sdk/credential-providers"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…lineDetails (#9712)

* Remove unnecessary getVersionTemplate() api call in pipeline details
router.

* Add an unit test.

* Update unit tests.

* Separate the unit test for 2 cases (undefined and invalid pipeline_spec)

* Add log error for undefined pipeline_spec case.
* fix(backend): Fix performance issue within a mysql request

Reprace the existing mysql request that use nested select, with inner join for better performance.
The fix levarage 'SQLDialect' interface, because the new request is not supported by sqllite (used for testing)
This interface bridges the difference between mysql (production) and sqlite
// (test)
Issue: kubeflow/pipelines#6845

Signed-off-by: diana <[email protected]>

* For sqlite use UPDATE FROM to join the target table against another table in the database in order to help compute

Try to generalize the method in SQLDialect interface

Signed-off-by: diana <[email protected]>

* Add unit tests

Signed-off-by: diana <[email protected]>

* Replace nested query for Jobs and start using pre-comit

Signed-off-by: diana <[email protected]>

* Fix: Use LEFT JOIN instead of INNER JOIN

Signed-off-by: diana <[email protected]>

---------

Signed-off-by: diana <[email protected]>
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
PiperOrigin-RevId: 547954593
…on to 1.25 in tests (#9743)

* Set image-type to cos_containerd in tests

Reverting the previous change #9705 which removed the `--image-type`.

/hold

Check if this resolves [e2e test failures](https://oss.gprow.dev/view/gs/oss-prow/pr-logs/pull/kubeflow_pipelines/9730/kubeflow-pipeline-e2e-test/1680988618279096320#1:build-log.txt%3A2) in #9730

* Update deploy-cluster.sh

* Set cluster-version to 1.25.10-gke.1200
…730)

* fix(backend) Replace LEFT with INNER JOIN when Archive Experiment

Signed-off-by: diana <[email protected]>

* Replace FEFT JOIN With INNER JOIN

Signed-off-by: diana <[email protected]>

---------

Signed-off-by: diana <[email protected]>
PiperOrigin-RevId: 549055602
* Initiate a new k8s client when calling _get_resource

* Remove k8s_client for methods that use _get_resource

* Initiate a new k8s client when calling _delete_resource
PiperOrigin-RevId: 549075960
…rom --metrics and --problem_type parameters

PiperOrigin-RevId: 549107922
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yhwang
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhwang
Copy link
Member Author

yhwang commented Oct 27, 2023

CI jobs passed, except the CLA. this is a sync-up PR. let me merge it.

@yhwang yhwang merged commit a4546ac into kubeflow:2.0.x Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.