allow using custom harbor repository in tmf&tapm #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
0xff-dev,
Abirdcfly,
bjwswang,
Lanture1064 and
nkwangleiGIT
bjwswang
requested changes
Mar 12, 2024
bjwswang
reviewed
Apr 16, 2024
| @@ -4,8 +4,8 @@ | |||
| replicaCount: 1 | |||
|
|
|||
| image: | |||
| registry: 192.168.90.214 | |||
| repository: system_containers/apm-api | |||
| registry: 192.168.90.214/system_containers | |||
There was a problem hiding this comment.
why harcode registry to 192.168.90.214?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
allow using custom harbor repository in tmf&tapm
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer