Add api support to return to the download link #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayuy
approved these changes
Jan 11, 2024
apiserver/service/minio_server.go
Outdated
|
|
||
| u, err := source.Core.PresignedGetObject(ctx.Request.Context(), bucket, objectName, time.Hour*24*7, url.Values{}) | ||
| if err != nil { | ||
| klog.Errorf("failed to get generate download link %s", err) |
There was a problem hiding this comment.
- failed to get generate download link =》two verbs here, it should be 'generate'?
- 24*7 hour is some too long, I think 12 hour is enough if we'll generate a new one for each API call.
| @@ -749,6 +790,7 @@ func RegisterMinIOAPI(group *gin.RouterGroup, conf gqlconfig.ServerConfig) { | |||
| group.DELETE("/model/files", auth.AuthInterceptor(conf.EnableOIDC, oidc.Verifier, "delete", "models"), api.DeleteFiles) | |||
| group.GET("/model/files/stat", auth.AuthInterceptor(conf.EnableOIDC, oidc.Verifier, "get", "models"), api.StatFile) | |||
| group.GET("/model/files/download", auth.AuthInterceptor(conf.EnableOIDC, oidc.Verifier, "get", "models"), api.Download) | |||
| group.GET("/model/files/downloadlink", auth.AuthInterceptor(conf.EnableOIDC, oidc.Verifier, "get", "models"), api.GetDownloadLink) | |||
There was a problem hiding this comment.
@0xff-dev do we think about RBAC check for APIs? I think we just validate OIDC token for now, right?
There was a problem hiding this comment.
auth.AuthInterceptor function is to verify that the current user has get access to the model resource based on the token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
feat: add api support to return to the download link
Which issue(s) this PR fixes
Fix #534
Special notes for your reviewer