Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove spec.input and spec.output of app node crd #468

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

Abirdcfly
Copy link
Collaborator

@Abirdcfly Abirdcfly commented Dec 28, 2023

What type of PR is this?

What this PR does / why we need it

  1. remove input and output field in crd.
  2. add node input output rule to annotation.
  3. when use knowledgebase, we can add a node ref to this knowledgebase.
  4. graphql application api will get default value when first create.

Which issue(s) this PR fixes

Fixes #457

Special notes for your reviewer

@Abirdcfly Abirdcfly changed the title feat: add more detail log in chat api refactor: remove spec.input and spec.output of app node crd Dec 28, 2023
@Abirdcfly Abirdcfly force-pushed the crd branch 11 times, most recently from a4f482b to 3ce6267 Compare December 28, 2023 08:35
@Abirdcfly Abirdcfly marked this pull request as ready for review December 28, 2023 08:42
@Abirdcfly Abirdcfly force-pushed the crd branch 2 times, most recently from 3ec87e5 to 7cac384 Compare December 28, 2023 09:12
@bjwswang
Copy link
Collaborator

@Abirdcfly Please consider to add a new group llms.arcadia.kubeagi.k8s.com.cn under app-node which act as :

A caller to a LLM

@bjwswang bjwswang merged commit e68d24e into kubeagi:main Dec 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate the name field in Input and Output in all api/app-node resources.
2 participants