-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add find_all
method to Store
#1634
Conversation
b3348dc
to
9f04a48
Compare
I tried to return an Slice or an iterator but it requires a collect anyway because store is behind a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! LGTM.
(Please disregard lint error, false positive known issue silenced in #1636 )
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
=======================================
- Coverage 75.3% 75.3% -0.0%
=======================================
Files 82 82
Lines 7348 7351 +3
=======================================
Hits 5528 5528
- Misses 1820 1823 +3
|
can't you move the RwLockReadGuard into the returned iterator? |
I don't understand your point @SOF3 . Could you elaborate on it a bit? |
9f04a48
to
2da179a
Compare
Resolves kube-rs#1633. Signed-off-by: Alexander Gil <[email protected]>
2da179a
to
1882a3f
Compare
I am just confused why we need so many special methods on |
@SOF3 that's a good point. In deed, we already have the I can close this and use that method. Thank you both. |
Resolves #1633.
Motivation
Solution