Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: rename references from Flatten to Decode #1520

Merged
merged 11 commits into from
Oct 4, 2024

fix deny..

5a70ab4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

runtime: rename references from Flatten to Decode #1520

fix deny..
5a70ab4
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 3, 2024 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.83.0-nightly (18b1161ec 2024-10-02)
  • cargo 1.83.0-nightly (80d82ca22 2024-09-27)
  • clippy 0.1.83 (18b1161 2024-10-02)

Annotations

Check warning on line 46 in e2e/job.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
  --> e2e/job.rs:46:7
   |
46 |     Ok(())
   |       ^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
   |
46 |     OkOk(())
   |       ~~~~~~

Check warning on line 12 in e2e/boot.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
  --> e2e/boot.rs:12:7
   |
12 |     Ok(())
   |       ^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
   |
12 ~     Okfor p in pods.list(&Default::default()).await? {
13 +         tracing::info!("Found pod {}", p.name_any());
14 +     }
15 +     Ok(())
   |

Check warning on line 268 in kube-client/src/api/core_methods.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty lines after doc comment

warning: empty lines after doc comment
   --> kube-client/src/api/core_methods.rs:264:5
    |
264 | /     /// use apiexts::CustomResourceDefinition;
265 | |
266 | |     /// # async fn wrapper() -> Result<(), Box<dyn std::error::Error>> {
267 | |     /// # let client: kube::Client = todo!();
268 | |
    | |_
...
276 |       pub async fn delete(&self, name: &str, dp: &DeleteParams) -> Result<Either<K, Status>> {
    |       -------------------------------------------------------------------------------------- the comment documents this method
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = help: if the empty lines are unintentional remove them
help: if the documentation should include the empty lines include them in the comment
    |
265 +     ///
266 |     /// # async fn wrapper() -> Result<(), Box<dyn std::error::Error>> {
267 |     /// # let client: kube::Client = todo!();
268 +     ///
    |

Check warning on line 151 in kube-client/src/api/core_methods.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty line after doc comment

warning: empty line after doc comment
   --> kube-client/src/api/core_methods.rs:150:5
    |
150 | /     /// use k8s_openapi::api::core::v1::Pod;
151 | |
    | |_
...
165 |       pub async fn get_metadata_opt(&self, name: &str) -> Result<Option<PartialObjectMeta<K>>> {
    |       ---------------------------------------------------------------------------------------- the comment documents this method
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
    = help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
    |
151 |     ///
    |

Check warning on line 103 in kube-core/src/object.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty line after doc comment

warning: empty line after doc comment
   --> kube-core/src/object.rs:102:5
    |
102 | /     /// }
103 | |
    | |_
104 |       pub fn iter_mut(&mut self) -> impl Iterator<Item = &mut T> {
    |       ---------------------------------------------------------- the comment documents this method
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
    = help: if the empty line is unintentional remove it