Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to hyper 1 #1438

Merged
merged 2 commits into from
Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/rust:1.72.0-bullseye
FROM docker.io/rust:1.75.0-bullseye

ENV DEBIAN_FRONTEND=noninteractive
RUN apt update && apt upgrade -y
Expand Down
26 changes: 14 additions & 12 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,15 @@ form_urlencoded = "1.2.0"
futures = "0.3.17"
hashbrown = "0.14.0"
home = "0.5.4"
http = "0.2.9"
http-body = "0.4.2"
hyper = "0.14.27"
hyper-openssl = "0.9.2"
hyper-rustls = "0.24.0"
hyper-socks2 = { version = "0.8.0", default-features = false }
hyper-timeout = "0.4.1"
http = "1.1.0"
http-body = "1.0.0"
http-body-util = "0.1.1"
hyper = "1.2.0"
hyper-util = "0.1.3"
hyper-openssl = "0.10.2"
hyper-rustls = "0.26.0"
hyper-socks2 = { version = "0.9.0", default-features = false }
hyper-timeout = "0.5.1"
json-patch = "1.0.0"
jsonpath-rust = "0.5.0"
k8s-openapi = { version = "0.21.0", default-features = false }
Expand All @@ -47,24 +49,24 @@ pin-project = "1.0.4"
proc-macro2 = "1.0.29"
quote = "1.0.10"
rand = "0.8.3"
rustls = "0.21.4"
rustls-pemfile = "1.0.0"
rustls = "0.22.0"
rustls-pemfile = "2.0.0"
schemars = "0.8.6"
secrecy = "0.8.0"
serde = "1.0.130"
serde_json = "1.0.68"
serde_yaml = "0.9.19"
smallvec = "1.7.0"
syn = "2.0.38"
tame-oauth = "0.9.1"
tame-oauth = "0.10.0"
tempfile = "3.1.0"
thiserror = "1.0.29"
tokio = "1.14.0"
tokio-test = "0.4.0"
tokio-tungstenite = "0.20.0"
tokio-tungstenite = "0.21.0"
tokio-util = "0.7.0"
tower = "0.4.13"
tower-http = "0.4.0"
tower-http = "0.5.2"
tower-test = "0.4.0"
tracing = "0.1.36"
tracing-subscriber = "0.3.17"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# kube-rs

[![Crates.io](https://img.shields.io/crates/v/kube.svg)](https://crates.io/crates/kube)
[![Rust 1.72](https://img.shields.io/badge/MSRV-1.72-dea584.svg)](https://github.com/rust-lang/rust/releases/tag/1.72.0)
[![Rust 1.75](https://img.shields.io/badge/MSRV-1.75-dea584.svg)](https://github.com/rust-lang/rust/releases/tag/1.75.0)
[![Tested against Kubernetes v1_24 and above](https://img.shields.io/badge/MK8SV-v1_24-326ce5.svg)](https://kube.rs/kubernetes-version)
[![Best Practices](https://bestpractices.coreinfrastructure.org/projects/5413/badge)](https://bestpractices.coreinfrastructure.org/projects/5413)
[![Discord chat](https://img.shields.io/discord/500028886025895936.svg?logo=discord&style=plastic)](https://discord.gg/tokio)
Expand Down
5 changes: 4 additions & 1 deletion examples/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,14 @@ tar = "0.4.37"
tracing.workspace = true
tracing-subscriber.workspace = true
warp = { version = "0.3", default-features = false, features = ["tls"] }
bytes.workspace = true
http.workspace = true
http-body-util.workspace = true
json-patch.workspace = true
tower = { workspace = true, features = ["limit"] }
tower-http = { workspace = true, features = ["trace", "decompression-gzip"] }
hyper = { workspace = true, features = ["client", "http1", "stream", "tcp"] }
hyper = { workspace = true, features = ["client", "http1"] }
hyper-util = { workspace = true, features = ["client-legacy", "http1", "tokio"] }
thiserror.workspace = true
backoff.workspace = true
clap = { version = "4.0", default-features = false, features = ["std", "cargo", "derive"] }
Expand Down
3 changes: 2 additions & 1 deletion examples/custom_client.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use hyper_util::rt::TokioExecutor;
// Minimal custom client example.
use k8s_openapi::api::core::v1::Pod;
use tracing::*;
Expand All @@ -14,7 +15,7 @@ async fn main() -> anyhow::Result<()> {
let service = tower::ServiceBuilder::new()
.layer(config.base_uri_layer())
.option_layer(config.auth_layer()?)
.service(hyper::Client::builder().build(https));
.service(hyper_util::client::legacy::Client::builder(TokioExecutor::new()).build(https));
let client = Client::new(service, config.default_namespace);

let pods: Api<Pod> = Api::default_namespaced(client);
Expand Down
5 changes: 3 additions & 2 deletions examples/custom_client_tls.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use hyper_util::rt::TokioExecutor;
// Custom client supporting both openssl-tls and rustls-tls
// Must enable `rustls-tls` feature to run this.
// Run with `USE_RUSTLS=1` to pick rustls.
Expand All @@ -19,13 +20,13 @@ async fn main() -> anyhow::Result<()> {
let https = config.openssl_https_connector()?;
let service = ServiceBuilder::new()
.layer(config.base_uri_layer())
.service(hyper::Client::builder().build(https));
.service(hyper_util::client::legacy::Client::builder(TokioExecutor::new()).build(https));
Client::new(service, config.default_namespace)
} else {
let https = config.rustls_https_connector()?;
let service = ServiceBuilder::new()
.layer(config.base_uri_layer())
.service(hyper::Client::builder().build(https));
.service(hyper_util::client::legacy::Client::builder(TokioExecutor::new()).build(https));
Client::new(service, config.default_namespace)
};

Expand Down
12 changes: 8 additions & 4 deletions examples/custom_client_trace.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
// Custom client example with TraceLayer.
use http::{Request, Response};
use hyper::Body;
use hyper::body::Incoming;
use hyper_util::rt::TokioExecutor;
use k8s_openapi::api::core::v1::Pod;
use std::time::Duration;
use tower::ServiceBuilder;
use tower_http::{decompression::DecompressionLayer, trace::TraceLayer};
use tracing::{Span, *};

use kube::{client::ConfigExt, Api, Client, Config, ResourceExt};
use kube::{
client::{Body, ConfigExt},
Api, Client, Config, ResourceExt,
};

#[tokio::main]
async fn main() -> anyhow::Result<()> {
Expand Down Expand Up @@ -40,7 +44,7 @@ async fn main() -> anyhow::Result<()> {
.on_request(|request: &Request<Body>, _span: &Span| {
tracing::debug!("payload: {:?} headers: {:?}", request.body(), request.headers())
})
.on_response(|response: &Response<Body>, latency: Duration, span: &Span| {
.on_response(|response: &Response<Incoming>, latency: Duration, span: &Span| {
let status = response.status();
span.record("http.status_code", status.as_u16());
if status.is_client_error() || status.is_server_error() {
Expand All @@ -49,7 +53,7 @@ async fn main() -> anyhow::Result<()> {
tracing::debug!("finished in {}ms", latency.as_millis())
}),
)
.service(hyper::Client::builder().build(https));
.service(hyper_util::client::legacy::Client::builder(TokioExecutor::new()).build(https));

let client = Client::new(service, config.default_namespace);

Expand Down
11 changes: 7 additions & 4 deletions examples/pod_portforward_hyper_http.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
use bytes::Bytes;
use hyper_util::rt::TokioIo;
use k8s_openapi::api::core::v1::Pod;
use kube::{
api::{Api, DeleteParams, PostParams},
Expand All @@ -6,7 +8,8 @@ use kube::{
};
use tracing::*;

use hyper::{body, Body, Request};
use http::Request;
use http_body_util::BodyExt;

#[tokio::main]
async fn main() -> anyhow::Result<()> {
Expand Down Expand Up @@ -37,7 +40,7 @@ async fn main() -> anyhow::Result<()> {
let port = pf.take_stream(80).unwrap();

// let hyper drive the HTTP state in our DuplexStream via a task
let (mut sender, connection) = hyper::client::conn::handshake(port).await?;
let (mut sender, connection) = hyper::client::conn::http1::handshake(TokioIo::new(port)).await?;
tokio::spawn(async move {
if let Err(e) = connection.await {
warn!("Error in connection: {}", e);
Expand All @@ -49,13 +52,13 @@ async fn main() -> anyhow::Result<()> {
.header("Connection", "close")
.header("Host", "127.0.0.1")
.method("GET")
.body(Body::from(""))
.body(http_body_util::Empty::<Bytes>::new())
.unwrap();

let (parts, body) = sender.send_request(http_req).await?.into_parts();
assert!(parts.status == 200);

let body_bytes = body::to_bytes(body).await?;
let body_bytes = body.collect().await?.to_bytes();
let body_str = std::str::from_utf8(&body_bytes)?;
assert!(body_str.contains("Welcome to nginx!"));

Expand Down
3 changes: 0 additions & 3 deletions examples/request_raw.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ use k8s_openapi::{api::core::v1::Node, apimachinery::pkg::api::resource::Quantit
use kube::{api::ListParams, Api, ResourceExt};
use serde::Deserialize;


#[tokio::main]
async fn main() -> anyhow::Result<()> {
let client = kube::Client::try_default().await?;
Expand Down Expand Up @@ -89,7 +88,6 @@ enum Metric {
Memory { usage_bytes: usize },
}


fn print_table(summaries: Vec<NodeSummary>) {
use headers::*;

Expand Down Expand Up @@ -142,7 +140,6 @@ fn print_table(summaries: Vec<NodeSummary>) {
}
}


// === impl Metric ===

impl Metric {
Expand Down
12 changes: 7 additions & 5 deletions kube-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ repository = "https://github.com/kube-rs/kube"
readme = "../README.md"
keywords = ["kubernetes", "client",]
categories = ["web-programming::http-client", "configuration", "network-programming", "api-bindings"]
rust-version = "1.72.0"
rust-version = "1.75.0"
edition = "2021"

[features]
Expand All @@ -24,7 +24,7 @@ kubelet-debug = ["ws", "kube-core/kubelet-debug"]
oauth = ["client", "tame-oauth"]
oidc = ["client", "form_urlencoded"]
gzip = ["client", "tower-http/decompression-gzip"]
client = ["config", "__non_core", "hyper", "http-body", "tower", "tower-http", "hyper-timeout", "pin-project", "chrono", "jsonpath-rust", "bytes", "futures", "tokio", "tokio-util", "either"]
client = ["config", "__non_core", "hyper", "hyper-util", "http-body", "http-body-util", "tower", "tower-http", "hyper-timeout", "pin-project", "chrono", "jsonpath-rust", "bytes", "futures", "tokio", "tokio-util", "either"]
jsonpatch = ["kube-core/jsonpatch"]
admission = ["kube-core/admission"]
config = ["__non_core", "pem", "home"]
Expand All @@ -48,19 +48,21 @@ serde_json.workspace = true
serde_yaml = { workspace = true, optional = true }
http.workspace = true
http-body = { workspace = true, optional = true }
http-body-util = { workspace = true, optional = true }
either = { workspace = true, optional = true }
thiserror.workspace = true
futures = { workspace = true, optional = true }
pem = { workspace = true, optional = true }
openssl = { workspace = true, optional = true }
rustls = { workspace = true, features = ["dangerous_configuration"], optional = true }
rustls = { workspace = true, optional = true }
rustls-pemfile = { workspace = true, optional = true }
bytes = { workspace = true, optional = true }
tokio = { workspace = true, features = ["time", "signal", "sync"], optional = true }
kube-core = { path = "../kube-core", version = "=0.88.1" }
jsonpath-rust = { workspace = true, optional = true }
tokio-util = { workspace = true, features = ["io", "codec"], optional = true }
hyper = { workspace = true, features = ["client", "http1", "stream", "tcp"], optional = true }
hyper = { workspace = true, features = ["client", "http1"], optional = true }
hyper-util = { workspace = true, features = ["client", "client-legacy", "http1", "tokio"], optional = true }
hyper-rustls = { workspace = true, optional = true }
hyper-socks2 = { workspace = true, optional = true }
tokio-tungstenite = { workspace = true, optional = true }
Expand All @@ -72,7 +74,7 @@ pin-project = { workspace = true, optional = true }
rand = { workspace = true, optional = true }
secrecy = { workspace = true, features = ["alloc", "serde"] }
tracing = { workspace = true, features = ["log"], optional = true }
hyper-openssl = { workspace = true, optional = true }
hyper-openssl = { workspace = true, features = ["client-legacy"], optional = true }
form_urlencoded = { workspace = true, optional = true }
k8s-openapi= { workspace = true, features = [] }

Expand Down
3 changes: 1 addition & 2 deletions kube-client/src/api/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,10 @@ impl<K> Debug for Api<K> {
/// Sanity test on scope restrictions
#[cfg(test)]
mod test {
use crate::{Api, Client};
use crate::{client::Body, Api, Client};
use k8s_openapi::api::core::v1 as corev1;

use http::{Request, Response};
use hyper::Body;
use tower_test::mock;

#[tokio::test]
Expand Down
4 changes: 4 additions & 0 deletions kube-client/src/client/auth/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ pub enum Error {
/// cluster spec missing while `provideClusterInfo` is true
#[error("Cluster spec must be populated when `provideClusterInfo` is true")]
ExecMissingClusterInfo,

/// No valid native root CA certificates found
#[error("No valid native root CA certificates found")]
NoValidNativeRootCA(#[source] std::io::Error),
}

#[derive(Debug, Clone)]
Expand Down
17 changes: 13 additions & 4 deletions kube-client/src/client/auth/oauth.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
use http_body_util::BodyExt;
use hyper_util::rt::TokioExecutor;
use tame_oauth::{
gcp::{TokenOrRequest, TokenProvider, TokenProviderWrapper},
Token,
};
use thiserror::Error;

use crate::client::Body;

#[derive(Error, Debug)]
/// Possible errors when requesting token with OAuth
pub enum Error {
Expand Down Expand Up @@ -33,7 +37,7 @@

/// Failed to request token
#[error("failed to request token: {0}")]
RequestToken(#[source] hyper::Error),
RequestToken(#[source] hyper_util::client::legacy::Error),

/// Failed to retrieve new credential
#[error("failed to retrieve new credential {0:?}")]
Expand All @@ -51,6 +55,10 @@
#[error("failed to build request: {0}")]
BuildRequest(#[source] http::Error),

/// No valid native root CA certificates found
#[error("No valid native root CA certificates found")]
NoValidNativeRootCA(#[source] std::io::Error),

/// OAuth failed with unknown reason
#[error("unknown OAuth error: {0}")]
Unknown(String),
Expand Down Expand Up @@ -113,22 +121,23 @@
#[cfg(feature = "rustls-tls")]
let https = hyper_rustls::HttpsConnectorBuilder::new()
.with_native_roots()
.map_err(Error::NoValidNativeRootCA)?

Check warning on line 124 in kube-client/src/client/auth/oauth.rs

View check run for this annotation

Codecov / codecov/patch

kube-client/src/client/auth/oauth.rs#L124

Added line #L124 was not covered by tests
.https_only()
.enable_http1()
.build();
#[cfg(all(not(feature = "rustls-tls"), feature = "openssl-tls"))]
let https =
hyper_openssl::HttpsConnector::new().map_err(Error::CreateOpensslHttpsConnector)?;

let client = hyper::Client::builder().build::<_, hyper::Body>(https);
let client = hyper_util::client::legacy::Client::builder(TokioExecutor::new()).build(https);

Check warning on line 132 in kube-client/src/client/auth/oauth.rs

View check run for this annotation

Codecov / codecov/patch

kube-client/src/client/auth/oauth.rs#L132

Added line #L132 was not covered by tests

let res = client
.request(request.map(hyper::Body::from))
.request(request.map(Body::from))

Check warning on line 135 in kube-client/src/client/auth/oauth.rs

View check run for this annotation

Codecov / codecov/patch

kube-client/src/client/auth/oauth.rs#L135

Added line #L135 was not covered by tests
.await
.map_err(Error::RequestToken)?;
// Convert response body to `Vec<u8>` for parsing.
let (parts, body) = res.into_parts();
let bytes = hyper::body::to_bytes(body).await.map_err(Error::ConcatBuffers)?;
let bytes = body.collect().await.map_err(Error::ConcatBuffers)?.to_bytes();

Check warning on line 140 in kube-client/src/client/auth/oauth.rs

View check run for this annotation

Codecov / codecov/patch

kube-client/src/client/auth/oauth.rs#L140

Added line #L140 was not covered by tests
let response = http::Response::from_parts(parts, bytes.to_vec());
match self.provider.parse_token_response(scope_hash, response) {
Ok(token) => Ok(token),
Expand Down
Loading
Loading