Fix connector shadowing to fix no-tls build
#1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excessive shadowing to avoid `connector` being an undefined var for no-tls build. for #1333 Signed-off-by: clux <[email protected]>
clux
force-pushed
the
fix-connector-shadowing
branch
from
48bc1ae to
4b6e3c7
Compare
Signed-off-by: clux <[email protected]>
Closed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
=====================================
Coverage 72.1% 72.1%
=====================================
Files 75 75
Lines 6377 6377
=====================================
Hits 4597 4597
Misses 1780 1780
|
spotted in upstream discussion Signed-off-by: clux <[email protected]>
Dav1dde
approved these changes
Nov 1, 2023
Signed-off-by: clux <[email protected]>
nightkr
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature test on linux for no-tls. Maybe we need to do
cargo hackin the future.includes a relatively minor fix to no-tls; only bail when scheme is https.