Properly cleanup and abort if rsync crashes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good @greezybacon , I would also add it line 348 as it can happened there (I've had a very bad network these last few days). |
|
@raphyduck just checking, but the check should be made around line 411, when the remote job is waited on, correct? |
|
Not sure what it was before but I like what you did now |
|
@raphyduck I've merged both this and the transaction PR into a branch in my repo, to-infinity-and-beyond. If you want to test them together, I'd welcome more feedback. |
|
@greezybacon Thanks, I cloned the branch and will be testing over the next few days. |
|
So far so good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch causes bitpocket to crash nicely if rsync does not completely cleanly.