KTOR-8061 MicrometerMetricsConfig add UptimeMetrics to standard meterBinders #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIMULATAN
added a commit
to SnotyMe/snoty-backend
that referenced
this pull request
Jan 4, 2025
Can be reverted once ktorio/ktor#4579 is merged
SIMULATAN
added a commit
to SnotyMe/snoty-backend
that referenced
this pull request
Jan 4, 2025
Can be reverted once ktorio/ktor#4579 is merged
e5l
approved these changes
Jan 13, 2025
osipxd
changed the title
osipxd
force-pushed
the
ktor-server-metrics-micrometer/uptime-metrics
branch
from
7e5820e to
326d32c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Server - Plugin Micrometer
Motivation
Lots of standard dashboards include the JVM process uptime / start time. The default Ktor Micrometer Plugin doesn't include this metric, causing panels referencing it to be empty.
Solution
Add the incredibly simple UptimeMetrics MeterBinder. It adds the
process.uptimeandprocess.start.timemetrics.