Treat commas as date separators if left straggling at the end

kspurgin · Jan 24, 2024 · 4521afb · 4521afb
1 parent b42e9da
commit 4521afb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/lib/emendate/date_segmenter.rb b/lib/emendate/date_segmenter.rb
@@ -26,7 +26,7 @@ def call
         apply_modifiers(mod) until working.empty?
       end
 
-      separators = result.select { |seg| %i[and or].include?(seg.type) }
+      separators = result.select { |seg| %i[and or comma].include?(seg.type) }
       return Success(result) if separators.empty?
 
       if separators.map(&:type).uniq.length > 1

diff --git a/spec/emendate/date_segmenter_spec.rb b/spec/emendate/date_segmenter_spec.rb
@@ -27,6 +27,15 @@
     end
   end
 
+  context "with ####, ####" do
+    let(:string) { "1997, 2000" }
+
+    it "segments as expected" do
+      expect(types).to eq(%i[year_date_type date_separator year_date_type])
+      expect(result.lexeme).to eq(string)
+    end
+  end
+
   context "with ####/##", :unambiguous_year_year do
     let(:string) { "1997/98" }
 

diff --git a/spec/emendate/range_indicator_spec.rb b/spec/emendate/range_indicator_spec.rb
@@ -48,7 +48,8 @@
     let(:str) { "1970, 1972 - 1999, 2002" }
 
     it "returns range_date_type" do
-      expect(type_string).to eq("year_date_type comma range_date_type comma "\
+      expect(type_string).to eq("year_date_type date_separator "\
+                                "range_date_type date_separator "\
                                 "year_date_type")
       expect(subject.lexeme).to eq(str)
     end