Skip to content

Commit

Permalink
🐛 fixed issue [bug] Stopwatch doesn't save hours if a time greater th…
Browse files Browse the repository at this point in the history
…an an hour is tracked #221

⬆️ updated package dependencies
  • Loading branch information
faburem committed Nov 18, 2024
1 parent 9c5060f commit 34d2455
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 11 deletions.
3 changes: 2 additions & 1 deletion imports/ui/pages/track/components/timetracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ Template.timetracker.events({
return
}
const duration = dayjs.preciseDiff(dayjs(), templateInstance.timer.get(), true)
const dayjsDuration = dayjs.duration(dayjs().diff(templateInstance.timer.get()))
const hours = (Number(duration.days * 24))
+ Number(duration.hours) + Number((duration.minutes / 60))
const project = templateInstance.project.get()
Expand All @@ -90,7 +91,7 @@ Template.timetracker.events({
$('#startTime').val(templateInstance.startTime.get())
}
if (getUserSetting('timeunit')==='m') {
$('#hours').val(duration.minutes)
$('#hours').val(dayjsDuration.asMinutes().toFixed(0).toString())
} else {
$('#hours').val(Number(hours).toFixed(getUserSetting('precision'))).trigger('change')
}
Expand Down
6 changes: 5 additions & 1 deletion imports/ui/pages/track/tracktime.js
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,11 @@ Template.tracktime.events({
hours: Number.parseInt(hoursString, 10),
minutes: Number.parseInt(minutesString, 10),
})
hours = duration.asHours().toString()
if (getUserSetting('timeunit') === 'h') {
hours = duration.asHours().toString()
} else if (getUserSetting('timeunit') === 'm') {
hours = duration.asMinutes().toString()
}
} else if (!hours && hours !== 0 && !Number.isNaN(hours)) {
templateInstance.$('#hours').addClass('is-invalid')
showToast(t('notifications.enter_time'))
Expand Down
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "titra",
"version": "0.99.19",
"version": "0.99.20",
"private": true,
"scripts": {
"start": "meteor run"
Expand Down Expand Up @@ -32,7 +32,7 @@
"jquery": "3.7.1",
"jquery-serializejson": "^3.2.1",
"ldapjs": "3.0.7",
"math-expression-evaluator": "^2.0.5",
"math-expression-evaluator": "^2.0.6",
"meteor-node-stubs": "^1.2.12",
"namedavatar": "^1.2.0",
"node-emoji": "^2.1.3",
Expand Down

0 comments on commit 34d2455

Please sign in to comment.