Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-bcrypt: Do not use lld when building with ptests on. #962

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

kraj
Copy link
Owner

@kraj kraj commented Jul 2, 2024

Somehow linker/lld here fails to link ptests with cargo, therefore workaround it by disabling lld when ptest feature is on.

Fixes errors like
note: riscv64-yoe-linux-ld.lld: error: undefined symbol: PyExc_ValueError\nreferenced by bcrypt_rust.a93ef5fbf090e743-cgu.0


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Somehow linker/lld here fails to link ptests with cargo, therefore
workaround it by disabling lld when ptest feature is on.

Fixes errors like
note: riscv64-yoe-linux-ld.lld: error: undefined symbol: PyExc_ValueError\nreferenced by bcrypt_rust.a93ef5fbf090e743-cgu.0

Signed-off-by: Khem Raj <[email protected]>
@kraj kraj merged commit a2f67ce into kraj:master Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant