Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "vte: Use libstdc++ when using clang" #1011

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

rossburton
Copy link
Contributor

@rossburton rossburton commented Sep 30, 2024

This issue has been resolved upstream:

https://gitlab.gnome.org/GNOME/vte/-/commit/c8838779d5f8c0e03411cef9775cd8f5a10a6204

This reverts commit 70295d7.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@rossburton rossburton requested a review from kraj as a code owner September 30, 2024 14:12
@kraj
Copy link
Owner

kraj commented Sep 30, 2024

@rossburton wouldn't we need a backport of the concerned patch into vte before reverting this one ?

@kraj
Copy link
Owner

kraj commented Sep 30, 2024

@rossburton wouldn't we need a backport of the concerned patch into vte before reverting this one ? the problem does occur in 0.78 release, so I am assuming the vte fix came after that release.

@rossburton
Copy link
Contributor Author

Yes, but 0.78 isn't merged yet.

Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the backport applied to 0.76 as well perhaps.

@kraj kraj merged commit 036ca82 into kraj:master Sep 30, 2024
1 check passed
@kraj
Copy link
Owner

kraj commented Oct 1, 2024

@rossburton Here is the new error after revert - https://errors.yoctoproject.org/Errors/Details/806338/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants