Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the grammer to explicitly support CURSOR variables in a declaration section. #46

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Extend the grammer to explicitly support CURSOR variables in a declaration section. #46

merged 1 commit into from
Jun 24, 2020

Conversation

hawicz
Copy link
Contributor

@hawicz hawicz commented Jun 17, 2020

To fix issue #45.

Also allow "COLLATE" and "DEFAULT" in regular variable declarations.

kputnam
kputnam requested changes Jun 17, 2020
View reviewed changes
Copy link
Owner

@kputnam kputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Could you add a small test file to example/proc/issue_45.sql to test a number of permutations that should be accepted by the grammar? You can follow the steps in example/README to check that it works.

@hawicz
Copy link
Contributor Author

hawicz commented Jun 17, 2020

This looks good! Could you add a small test file to example/proc/issue_45.sql to test a number of permutations that should be accepted by the grammar? You can follow the steps in example/README to check that it works.

Ok, will do.

@hawicz
Issue kputnam#45: Extend the grammer to explicitly support CURSOR var…
de26795 
…iables in a declaration section.

Also allow "COLLATE" and "DEFAULT" in regular variable declarations.
@kputnam kputnam merged commit 4176ee7 into kputnam:master Jun 24, 2020
@kputnam
Copy link
Owner

kputnam commented Jun 24, 2020

Thanks Eric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kputnam kputnam kputnam requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawicz @kputnam