Skip to content

Commit

Permalink
Remove/downgrade various TODO(euclid migration) comments.
Browse files Browse the repository at this point in the history
Most of these are more like further design issues than incomplete
migration.
  • Loading branch information
kpreid committed Nov 8, 2024
1 parent 5b83f81 commit 8392123
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion all-is-cubes-base/src/math/color.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ pub struct Rgba {

/// Unit-of-measure type for vectors that contain color channels.
//---
// TODO(euclid migration): Better name?
// TODO: replace this with formally accurate units.
#[expect(clippy::exhaustive_enums)]
#[derive(Debug, Eq, PartialEq)]
pub enum Intensity {}
Expand Down
1 change: 0 additions & 1 deletion all-is-cubes-base/src/raycast/ray.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ use crate::math::GridAab;
#[expect(clippy::exhaustive_structs)]
#[derive(Clone, Copy, Debug, PartialEq)]
pub struct Ray {
// TODO(euclid migration): should we expose the coordinate unit generic?
/// The sole endpoint of the ray.
pub origin: FreePoint,

Expand Down
3 changes: 1 addition & 2 deletions all-is-cubes-mesh/src/block_mesh/planar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,7 @@ pub(super) struct QuadTransform {
// TODO: specialize transforms since there are only 6 possible values plus scale,
// so we don't need as many ops as a full matrix-vector multiplication?
// Or would the branching needed make it pointless?
//
// TODO(euclid migration): We can at least make this a RigidTransform3D
// We can at least make this a euclid::RigidTransform3D.
position_transform: Transform3D<FreeCoordinate, Cube, Cube>,
texture_transform: Transform3D<TextureCoordinate, TexelUnit, TexelUnit>,
}
Expand Down
1 change: 0 additions & 1 deletion all-is-cubes-mesh/src/texture.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ use all_is_cubes::util::{ConciseDebug, Fmt};
pub(crate) type TextureCoordinate = f32;

/// Unit-of-measure identifier used with [`euclid`](all_is_cubes::euclid) for “whole texels”.
/// TODO(euclid migration): Better name, and a type alias for the point
#[expect(clippy::exhaustive_enums)]
#[derive(Debug)]
pub enum TexelUnit {}
Expand Down
2 changes: 1 addition & 1 deletion all-is-cubes-port/src/gltf/texture.rs
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ impl texture::Plane for GltfTexturePlane {
.rotation
.to_rotation_matrix()
.to_free()
.with_source::<texture::TexelUnit>() // TODO(euclid migration): clunky
.with_source::<texture::TexelUnit>() // TODO: avoid these unit changes by being able to get Transform3D straight from GridRotation
.with_destination::<texture::TexelUnit>()
.transform_point3d(tc_in_tile.map(f64::from))
.unwrap()
Expand Down
1 change: 0 additions & 1 deletion all-is-cubes/src/character.rs
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,6 @@ impl Character {
self.body.flying = flying;

let dt = tick.delta_t().as_secs_f64();
// TODO(euclid migration): take advantage of coordinate system types
let control_orientation = Rotation3D::around_y(-Angle::radians(self.body.yaw.to_radians()));
// TODO: apply pitch too, but only if wanted for flying (once we have not-flying)
let initial_body_velocity = self.body.velocity;
Expand Down

0 comments on commit 8392123

Please sign in to comment.