Added support for using wget to upgrade script without git

[cslycord]

Allows for upgrading script using wget to the raw direct location of the script at github.

Obviously, if you accept the change, it would need to have the URL uncommented to use your repo's location.

Other than that, shellcheck noticed the misspelling of the THRESHOLD_OF_WARNING variable and my editor automatically removed the unneeded tabs on empty lines and the unneeded spaces on the ends of a few lines here and there.

[kou1okada]

Thank you for a nice pull request.
But, I'm glad if you separate it to three of fixing a typo, rearranging spaces and upgrade-self without git.

[kou1okada]

And below URL is not good for pull request.

local updated_url='https://raw.githubusercontent.com/cslycord/apt-cyg/master/apt-cyg'

[cslycord]

Which is why I wrote that you must uncomment the line below that, which uses the URL for the script in your repository.

…

On Tue, Oct 29, 2019, 12:17 AM kou1okada ***@***.***> wrote: And below URL is not good for pull request. local updated_url='https://raw.githubusercontent.com/cslycord/apt-cyg/master/apt-cyg' — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#56?email_source=notifications&email_token=AC5TL7JN5FX3EYMQKDQWGM3QQ367PA5CNFSM4JFBV3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECNH3QI#issuecomment-546995649>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC5TL7LF22ITG7C7CNVE27LQQ367PANCNFSM4JFBV3XQ> .

[cslycord]

I can separate those into different pull requests. No worries. For what it's worth, I wasn't aware of the spacing changes until the pull request showed the diff, since the editor changed it automatically.

…

On Tue, Oct 29, 2019 at 12:11 AM kou1okada ***@***.***> wrote: Thank you for a nice pull request. But, I'm glad if you separate it to three of fixing a typo, rearranging spaces and upgrade-self without git. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#56?email_source=notifications&email_token=AC5TL7MEILD2RLOGBVEJ4R3QQ36IPA5CNFSM4JFBV3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECNHDPI#issuecomment-546992573>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC5TL7I6VBGCBMNR7JLXCD3QQ36IPANCNFSM4JFBV3XQ> .

[kou1okada]

Thank you to separate a pull request to three of below:

• Spacing Spacing #57
• Typo Typo #58
• Wget Wget #59

I'll be more happy if you drop intermediate commits each of final commits.

It can be achieved by interactive rebase with following steps:

Step 1: Start interactive rebase for last four commits.

git rebase -i HEAD~4

Step 2: Edit commit

pick d1e03eb changed upgrade-self to use wget
pick 64bdcf3 make upgrade-self wget portion quiet
pick 2d1a936 Fixed self-upgrade wget to use CLI args
pick xxxxxxx bla bla bla

to

pick d1e03eb changed upgrade-self to use wget
fixup 64bdcf3 make upgrade-self wget portion quiet
fixup 2d1a936 Fixed self-upgrade wget to use CLI args
squash xxxxxxx bla bla bla

and save it.

Step 3: Edit commit message as

• Drop commit message ♯1:
• Keep commit message ♯4:

and save it.

[kou1okada]

It'll changes commit hash, so you should use git push with -f option.

[cslycord]

I believe the intermediate commits should be fixed now.

…

On Tue, Oct 29, 2019 at 10:47 AM kou1okada ***@***.***> wrote: It'll changes commit hash, so you should use git push with -f option. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#56?email_source=notifications&email_token=AC5TL7KQIU7642LQUKQFS2DQQ6IZPA5CNFSM4JFBV3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECO6OTI#issuecomment-547219277>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC5TL7LZULUJTCNFNIE7NLDQQ6IZPANCNFSM4JFBV3XQ> .

[cslycord]

If not, I see that pushing the changes to the commits created new branches of "origin/name" and I'm not sure why.

…

On Tue, Oct 29, 2019 at 2:31 PM Chris Slycord ***@***.***> wrote: I believe the intermediate commits should be fixed now. On Tue, Oct 29, 2019 at 10:47 AM kou1okada ***@***.***> wrote: > It'll changes commit hash, so you should use git push with -f option. > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <#56?email_source=notifications&email_token=AC5TL7KQIU7642LQUKQFS2DQQ6IZPA5CNFSM4JFBV3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECO6OTI#issuecomment-547219277>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC5TL7LZULUJTCNFNIE7NLDQQ6IZPANCNFSM4JFBV3XQ> > . >

[kou1okada]

Check your current working branch with:

git log --all --graph --color --pretty=fuller --decorate=full --summary

Maybe it is not "name" but "origin/name".

And your "origin/wget" seems to be not rebased correctly.
It has typo, spacing and wget.

[cslycord]

It should be working now. I've got spacing, typo, and wget rebased.

…

On Wed, Oct 30, 2019 at 8:33 AM kou1okada ***@***.***> wrote: Check your current working branch with: git log --all --graph --color --pretty=fuller --decorate=full --summary Maybe it is not "name" but "origin/name". And your "origin/wget <https://github.com/cslycord/apt-cyg/tree/origin/wget>" seems to be not rebased correctly. It has typo, spacing and wget. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#56?email_source=notifications&email_token=AC5TL7LMI2UKCJG26U5O7VLQRDB3HA5CNFSM4JFBV3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECSNWYA#issuecomment-547674976>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC5TL7IBQ4YXL2OC6ZGKMBTQRDB3HANCNFSM4JFBV3XQ> .

[kou1okada]

Something wrong with your rebase.

I prepared three rebased branches to you.

• https://github.com/kou1okada/apt-cyg/tree/cslycord-wget-rebased
• https://github.com/kou1okada/apt-cyg/tree/cslycord-typo-rebased
• https://github.com/kou1okada/apt-cyg/tree/cslycord-spacing-rebased

Please do git reset --hard <above-branch> for your branches, and then do git push -f each for them.

[cslycord]

Should be done.

…

On Wed, Oct 30, 2019 at 6:02 PM kou1okada ***@***.***> wrote: Something wrong with your rebase. [image: image] <https://user-images.githubusercontent.com/1631846/67842763-23e0f400-fb3e-11e9-8293-cf1b8de4283d.png> I prepared three rebased branches to you. - https://github.com/kou1okada/apt-cyg/tree/cslycord-wget-rebased - https://github.com/kou1okada/apt-cyg/tree/cslycord-typo-rebased - https://github.com/kou1okada/apt-cyg/tree/cslycord-spacing-rebased Please do git reset --hard <above-branch> for your branches, and then do git push -f each for them. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#56?email_source=notifications&email_token=AC5TL7JYYX326THGECZMNJDQRFERDA5CNFSM4JFBV3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECTMVGY#issuecomment-547801755>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC5TL7I2PJ27AB7RWHNVCULQRFERDANCNFSM4JFBV3XQ> .

[kou1okada]

Thank you.
That seem good.