Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for passing in databaseID to schema #139

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ecaroth
Copy link

@ecaroth ecaroth commented Aug 22, 2024

This small PR adds support for optionally including a databaseId in your schema config, like so:

schema(($) => ({
            foor: $.collection<Foo>().sub({
                bar: $.collection<Bar>(),
            })
        }), {
            databaseId: 'my-database-id',
            // optionally specify unique databaseId for client or server options
            server: {app, databaseId: 'my-database-id'},
            client: {app, databaseId, databaseId: 'my-database-id'}
        }
    )

Other notes: Fixed a very small bug with unit test for averages and small errors with Options typing also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant