Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug introduced by dependabot #205 #206

Merged
merged 3 commits into from
Jul 15, 2024
Merged

fix bug introduced by dependabot #205 #206

merged 3 commits into from
Jul 15, 2024

Conversation

kortina
Copy link
Owner

@kortina kortina commented Jul 15, 2024

The dependabot update #205 updated a few libraries which caused the following errors:

 [email protected] compile
> ./node_modules/.bin/tsc -p ./

src/BacklinksTreeDataProvider.ts(148,7): error TS2611: 'command' is defined as a property in class 'TreeItem', but is overridden here in 'BacklinkItem' as an accessor.
src/BacklinksTreeDataProvider.ts(164,7): error TS2611: 'tooltip' is defined as a property in class 'TreeItem', but is overridden here in 'BacklinkItem' as an accessor.
src/BacklinksTreeDataProvider.ts(174,7): error TS2611: 'description' is defined as a property in class 'TreeItem', but is overridden here in 'BacklinkItem' as an accessor.
src/BacklinksTreeDataProvider.ts(193,7): error TS2611: 'iconPath' is defined as a property in class 'TreeItem', but is overridden here in 'BacklinkItem' as an accessor.

I resolved these by changing the command, tooltip, description, and iconPath accessors to be private functions which I then use to initialize the corresponding properties in the class constructor method.

I did a run with debug mode on and verified I was still seeing backlinks show up in the left sidebar:

image

@kortina kortina merged commit c6bdc88 into master Jul 15, 2024
2 checks passed
@kortina kortina deleted the ak-fix-broken-build branch July 15, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant