Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: some minor optimizations for reservation #2336

Merged

Conversation

saintube
Copy link
Member

@saintube saintube commented Feb 12, 2025

Ⅰ. Describe what this PR does

Scheduler: Reduce overhead by changing unnecessary DeepCopy to shallow copy and pre-allocating memory for a heavy map copy.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.90%. Comparing base (04292dc) to head (627e5e5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/frameworkext/reservation_info.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2336      +/-   ##
==========================================
- Coverage   65.92%   65.90%   -0.02%     
==========================================
  Files         466      466              
  Lines       54811    54812       +1     
==========================================
- Hits        36134    36125       -9     
- Misses      16067    16076       +9     
- Partials     2610     2611       +1     
Flag Coverage Δ
unittests 65.90% <57.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot merged commit 647df2f into koordinator-sh:main Feb 13, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants