Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix monitor terminating pod #2331

Conversation

saintube
Copy link
Member

@saintube saintube commented Feb 10, 2025

Ⅰ. Describe what this PR does

scheduler: Fix a bug where the pod is leaked in the schedulerMonitor's cache if it is terminating and then dequeues.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Co-authored-by: shenxin <[email protected]>
Signed-off-by: saintube <[email protected]>
@saintube saintube requested a review from ZiMengSheng February 10, 2025 08:18
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.06%. Comparing base (cc55177) to head (3fa4257).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
+ Coverage   66.05%   66.06%   +0.01%     
==========================================
  Files         464      464              
  Lines       54643    54651       +8     
==========================================
+ Hits        36092    36104      +12     
+ Misses      15943    15940       -3     
+ Partials     2608     2607       -1     
Flag Coverage Δ
unittests 66.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot merged commit 96ff411 into koordinator-sh:main Feb 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants