Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: add metrics for webhook #2330

Merged

Conversation

nce3xin
Copy link
Contributor

@nce3xin nce3xin commented Feb 10, 2025

koord-manager: add metrics for webhook

@nce3xin nce3xin force-pushed the main-webhook-add-metrics-alarm branch 2 times, most recently from ac0510f to e5b4754 Compare February 10, 2025 04:02
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 67.41573% with 29 lines in your changes missing coverage. Please review.

Project coverage is 66.05%. Comparing base (37bd292) to head (1db09bc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/webhook/pod/mutating/mutating_handler.go 60.00% 8 Missing ⚠️
pkg/webhook/cm/validating/validating_handler.go 0.00% 5 Missing ⚠️
pkg/webhook/pod/validating/validating_handler.go 77.27% 4 Missing and 1 partial ⚠️
pkg/webhook/metrics/webhook_duration.go 75.00% 2 Missing and 1 partial ⚠️
.../webhook/elasticquota/mutating/mutating_handler.go 60.00% 2 Missing ⚠️
...k/elasticquota/plugin_check_quota_meta_validate.go 0.00% 2 Missing ⚠️
pkg/webhook/node/mutating/mutating_handler.go 60.00% 2 Missing ⚠️
pkg/webhook/node/validating/validating_handler.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
+ Coverage   66.03%   66.05%   +0.01%     
==========================================
  Files         461      464       +3     
  Lines       54547    54643      +96     
==========================================
+ Hits        36022    36095      +73     
- Misses      15918    15942      +24     
+ Partials     2607     2606       -1     
Flag Coverage Δ
unittests 66.05% <67.41%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nce3xin nce3xin force-pushed the main-webhook-add-metrics-alarm branch from e5b4754 to 9100982 Compare February 10, 2025 06:07
@zwzhang0107 zwzhang0107 changed the title [koord-manager-webhook] add metrics koord-manager: add metrics for webhook Feb 10, 2025
@nce3xin nce3xin force-pushed the main-webhook-add-metrics-alarm branch from 9100982 to 1db09bc Compare February 10, 2025 07:05
@saintube
Copy link
Member

/lgtm

@saintube saintube added the lgtm label Feb 10, 2025
@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot koordinator-bot bot merged commit cc55177 into koordinator-sh:main Feb 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants