Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: support pouch container #1761

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

zwzhang0107
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (661dd71) 66.12% compared to head (8f835d5) 66.14%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/koordlet/util/runtime/handler/pouch_runtime.go 72.22% 10 Missing and 5 partials ⚠️
pkg/koordlet/util/runtime/runtime.go 57.14% 9 Missing and 3 partials ⚠️
pkg/koordlet/util/system/config.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1761      +/-   ##
==========================================
+ Coverage   66.12%   66.14%   +0.02%     
==========================================
  Files         388      390       +2     
  Lines       42476    42590     +114     
==========================================
+ Hits        28086    28172      +86     
- Misses      12315    12334      +19     
- Partials     2075     2084       +9     
Flag Coverage Δ
unittests 66.14% <68.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 5578532 into koordinator-sh:main Nov 30, 2023
19 checks passed
@zwzhang0107 zwzhang0107 deleted the support-pouch branch December 6, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants