-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: support pouch container #1761
koordlet: support pouch container #1761
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
==========================================
+ Coverage 66.12% 66.14% +0.02%
==========================================
Files 388 390 +2
Lines 42476 42590 +114
==========================================
+ Hits 28086 28172 +86
- Misses 12315 12334 +19
- Partials 2075 2084 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/koordlet/metricsadvisor/collectors/hostapplication/host_app_collector.go
Outdated
Show resolved
Hide resolved
ffbce18
to
38566c7
Compare
Signed-off-by: 佑祎 <[email protected]>
38566c7
to
8f835d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonliu747, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test