Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add CONTRIBUTE.md #173

Merged
merged 1 commit into from
Nov 22, 2024
Merged

📖 Add CONTRIBUTE.md #173

merged 1 commit into from
Nov 22, 2024

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Nov 20, 2024

No description provided.

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>

#### Rule IDs
Rule IDs must be unique within the rulesets being used, and contain in themselves the name of the rule file plus a
number. These numbers must have 5 digits and increase by 10 each time, to follow a convention set in the old Windup rules.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have to follow this convention set? It's confusing. Can't we just enforce this to be an incrementing integer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, although then we would have two different conventions. It's not super important, but just wanted to be homogeneous.

Copy link

@rromannissen rromannissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmle jmle merged commit c1b217f into konveyor:main Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants