🐛 Close analysis.log before generate static-report #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to containerless --bulk analysis on Windows. Remove of analysis.log silently failed since it was still opened (which appears on Windows), moving the file `Close()` from `defer` just before generating static-report. Fixes: https://issues.redhat.com/browse/MTA-4307 Signed-off-by: Marek Aufart <[email protected]>
aufi
added
the
cherry-pick/release-0.6
|
Succesfuly tested this change on Win10. |
|
The thing here, is that the defer will close the file on all of the error returns. from godoc: I think that right now we are just throwing away that error, so I would just add back the defer. It will error most times but that will be fine because we are not using it. |
|
Thanks for feedback @shawn-hurley! Just to be sure I understand correctly you're suggesting putting back file.Close in defer and keep file.Close also before static-report generation, correct? |
|
That is correct |
Signed-off-by: Marek Aufart <[email protected]>
shawn-hurley
approved these changes
Jan 22, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Close analysis.log before generate static-report Related to containerless --bulk analysis on Windows. Remove of analysis.log silently failed since it was still opened (which appears on Windows), moving the file `Close()` from `defer` just before generating static-report. Fixes: https://issues.redhat.com/browse/MTA-4307 Signed-off-by: Marek Aufart <[email protected]> * Re-add Close in defer Signed-off-by: Marek Aufart <[email protected]> --------- Signed-off-by: Marek Aufart <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
aufi
added a commit
that referenced
this pull request
Jan 24, 2025
…419) 🐛 Close analysis.log before generate static-report (#415) * Close analysis.log before generate static-report Related to containerless --bulk analysis on Windows. Remove of analysis.log silently failed since it was still opened (which appears on Windows), moving the file `Close()` from `defer` just before generating static-report. Fixes: https://issues.redhat.com/browse/MTA-4307 * Re-add Close in defer --------- Signed-off-by: Marek Aufart <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to containerless --bulk analysis on Windows. Remove of analysis.log silently failed since it was still opened (which appears on Windows only), moving the file
Close()fromdeferto just before generating static-report.If some error occured before reaching the Close, the file should be closed by golang garbage collector.
Fixes: https://issues.redhat.com/browse/MTA-4307